From: Radoslaw Zarzynski Date: Thu, 6 Dec 2018 10:05:38 +0000 (+0100) Subject: common: drop at_buffer_{head,tail} from buffer::ptr. X-Git-Tag: v14.1.0~606^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=52ebc8fb5d6e7fa9a85c23ff064ca40b2fb22c9d;p=ceph.git common: drop at_buffer_{head,tail} from buffer::ptr. Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/common/buffer.cc b/src/common/buffer.cc index b1c533ed3100..5be023f0a272 100644 --- a/src/common/buffer.cc +++ b/src/common/buffer.cc @@ -654,8 +654,6 @@ using namespace ceph; } } - bool buffer::ptr::at_buffer_tail() const { return _off + _len == _raw->len; } - int buffer::ptr::get_mempool() const { if (_raw) { return _raw->mempool; diff --git a/src/include/buffer.h b/src/include/buffer.h index 56c5e8154e28..ae491a5aea05 100644 --- a/src/include/buffer.h +++ b/src/include/buffer.h @@ -296,9 +296,6 @@ namespace buffer CEPH_BUFFER_API { } // misc - bool at_buffer_head() const { return _off == 0; } - bool at_buffer_tail() const; - bool is_aligned(unsigned align) const { return ((long)c_str() & (align-1)) == 0; } diff --git a/src/test/bufferlist.cc b/src/test/bufferlist.cc index beb094fd8313..a018bd561cb7 100644 --- a/src/test/bufferlist.cc +++ b/src/test/bufferlist.cc @@ -464,20 +464,6 @@ TEST(BufferPtr, have_raw) { } } -TEST(BufferPtr, at_buffer_head) { - bufferptr ptr(2); - EXPECT_TRUE(ptr.at_buffer_head()); - ptr.set_offset(1); - EXPECT_FALSE(ptr.at_buffer_head()); -} - -TEST(BufferPtr, at_buffer_tail) { - bufferptr ptr(2); - EXPECT_TRUE(ptr.at_buffer_tail()); - ptr.set_length(1); - EXPECT_FALSE(ptr.at_buffer_tail()); -} - TEST(BufferPtr, is_n_page_sized) { { bufferptr ptr(CEPH_PAGE_SIZE);