From: Patrick Donnelly <pdonnell@redhat.com>
Date: Tue, 31 Oct 2023 14:54:37 +0000 (-0400)
Subject: cmake: do not issue CMAKE_BUILD_TYPE warning if set
X-Git-Tag: v19.0.0~213^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=536b054167d7aff1d18490e94ed98fd41d3003a3;p=ceph.git

cmake: do not issue CMAKE_BUILD_TYPE warning if set

Fixes: b8c6ba01b262d33084b9c607d829503ac8ae25c5
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f5ea2c49b9a6..4feb22c135e1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -23,13 +23,15 @@ endforeach()
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules/")
 
-if(NOT CMAKE_BUILD_TYPE AND EXISTS "${CMAKE_SOURCE_DIR}/.git")
-  message(WARNING "CMAKE_BUILD_TYPE not specified, assuming CMAKE_BUILD_TYPE=Debug because .git exists.")
-  set(default_build_type "Debug")
-  set(CMAKE_BUILD_TYPE "${default_build_type}" CACHE
-      STRING "Default BUILD_TYPE is Debug, other options are: RelWithDebInfo, Release, and MinSizeRel." FORCE)
-else()
-  message(WARNING "CMAKE_BUILD_TYPE not specified, leaving unset because .git does NOT exist.")
+if(NOT CMAKE_BUILD_TYPE)
+  if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
+    message(WARNING "CMAKE_BUILD_TYPE not specified, assuming CMAKE_BUILD_TYPE=Debug because .git exists.")
+    set(default_build_type "Debug")
+    set(CMAKE_BUILD_TYPE "${default_build_type}" CACHE
+        STRING "Default BUILD_TYPE is Debug, other options are: RelWithDebInfo, Release, and MinSizeRel." FORCE)
+  else()
+    message(WARNING "CMAKE_BUILD_TYPE not specified, leaving unset because .git does NOT exist.")
+  endif()
 endif()
 
 if(CMAKE_SYSTEM_NAME MATCHES "Linux")