From: Kefu Chai <kchai@redhat.com>
Date: Wed, 19 May 2021 10:21:05 +0000 (+0800)
Subject: test/crimson: remove unnecessary local variable
X-Git-Tag: v17.1.0~1899^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5406dd2cfca577aa4836808eeb31cf18b1a400e0;p=ceph.git

test/crimson: remove unnecessary local variable

to return the return value of "make_unique<>()" is more readable, and more
consistent with other part of this source file.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/test/crimson/seastore/transaction_manager_test_state.h b/src/test/crimson/seastore/transaction_manager_test_state.h
index 9a1c51fdcbb7..a0146c45d74f 100644
--- a/src/test/crimson/seastore/transaction_manager_test_state.h
+++ b/src/test/crimson/seastore/transaction_manager_test_state.h
@@ -79,13 +79,12 @@ auto get_transaction_manager(
 
   journal->set_segment_provider(&*segment_cleaner);
 
-  auto ret = std::make_unique<TransactionManager>(
+  return std::make_unique<TransactionManager>(
     segment_manager,
     std::move(segment_cleaner),
     std::move(journal),
     std::move(cache),
     std::move(lba_manager));
-  return ret;
 }
 
 auto get_seastore(SegmentManagerRef sm) {