From: Mark Nelson <mnelson@redhat.com>
Date: Thu, 26 Mar 2020 20:16:46 +0000 (-0500)
Subject: common/options: Disable bluefs_buffered_io by default again.
X-Git-Tag: wip-pdonnell-testing-20200918.022351~1688^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=5574617b9f4cf950c108cb06cb6f9eb48396aa57;p=ceph-ci.git

common/options: Disable bluefs_buffered_io by default again.

Signed-off-by: Mark Nelson <mnelson@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 6d89f215bf1..ed8bc4a81a7 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4006,8 +4006,9 @@ std::vector<Option> get_global_options() {
     .set_description(""),
 
     Option("bluefs_buffered_io", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
-    .set_default(true)
-    .set_description(""),
+    .set_default(false)
+    .set_description("Enabled buffered IO for bluefs reads.")
+    .set_long_description("When this option is enabled, bluefs will in some cases perform buffered reads.  This allows the kernel page cache to act as a secondary cache for things like RocksDB compaction.  For example, if the rocksdb block cache isn't large enough to hold blocks from the compressed SST files itself, they can be read from page cache instead of from the disk.  This option previously was enabled by default, however in some test cases it appears to cause excessive swap utilization by the linux kernel and a large negative performance impact after several hours of run time.  Please exercise caution when enabling."),
 
     Option("bluefs_sync_write", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
     .set_default(false)