From: Igor Fedotov <igor.fedotov@croit.io>
Date: Mon, 22 Jul 2024 14:15:45 +0000 (+0300)
Subject: kv/rocksdb: return error for dump_objectstore_kv_stats asok command
X-Git-Tag: v20.0.0~1048^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=56504d2ad92b39c9b92134bec9cbe83f94ddca3f;p=ceph.git

kv/rocksdb: return error for dump_objectstore_kv_stats asok command
if relevant config settings result in no output.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
---

diff --git a/src/kv/RocksDBStore.cc b/src/kv/RocksDBStore.cc
index a653fa6398c2..bef87d15ed73 100644
--- a/src/kv/RocksDBStore.cc
+++ b/src/kv/RocksDBStore.cc
@@ -1417,8 +1417,13 @@ int64_t RocksDBStore::estimate_prefix_size(const string& prefix,
 void RocksDBStore::get_statistics(Formatter *f)
 {
   if (!cct->_conf->rocksdb_perf)  {
-    dout(20) << __func__ << " RocksDB perf is disabled, can't probe for stats"
-	     << dendl;
+    f->write_raw_data("error: RocksDB perf is disabled, can't probe for stats.\n");
+    return;
+  }
+  if (!cct->_conf->rocksdb_collect_compaction_stats &&
+      !cct->_conf->rocksdb_collect_extended_stats &&
+      !cct->_conf->rocksdb_collect_memory_stats)  {
+    f->write_raw_data("error: None of rocksdb_collect_* setting is enabled, hence no output.\n");
     return;
   }