From: Yehuda Sadeh <yehuda@hq.newdream.net>
Date: Fri, 5 Dec 2008 00:14:55 +0000 (-0800)
Subject: logmonitor: append all notifications in a single file
X-Git-Tag: v0.6~174
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5689c78ede26b1b6766b48a071a052ce9d9f85be;p=ceph.git

logmonitor: append all notifications in a single file
---

diff --git a/src/common/LogClient.cc b/src/common/LogClient.cc
index e88eab4e06e..d618ed3b69b 100644
--- a/src/common/LogClient.cc
+++ b/src/common/LogClient.cc
@@ -35,6 +35,12 @@
 
 #include "config.h"
 
+void LogClient::log(log_type type, const char *s)
+{
+  string str(s);
+  log(type, str);
+}
+
 void LogClient::log(log_type type, stringstream& ss)
 {
   while (!ss.eof()) {
diff --git a/src/common/LogClient.h b/src/common/LogClient.h
index fec14908e2f..a3ce141bdd3 100644
--- a/src/common/LogClient.h
+++ b/src/common/LogClient.h
@@ -39,6 +39,7 @@ class LogClient : public Dispatcher {
   deque<LogEntry> log_queue;
   version_t last_log;
 
+  void log(log_type type, const char *s);
   void log(log_type type, string& s);
   void log(log_type type, stringstream& s);
   void send_log();
diff --git a/src/mon/LogMonitor.cc b/src/mon/LogMonitor.cc
index 87bd37ff93c..d6c51769382 100644
--- a/src/mon/LogMonitor.cc
+++ b/src/mon/LogMonitor.cc
@@ -85,16 +85,44 @@ void LogMonitor::create_initial()
   e.type = LOG_INFO;
   e.msg = "mkfs";
   e.seq = 0;
-  stringstream ss;
-  ss << e;
-  string s;
-  getline(ss, s);
-  pending_inc.append(s);
-  pending_inc.append("\n");
+  e.encode(pending_inc);
 }
 
 bool LogMonitor::update_from_paxos()
 {
+  version_t paxosv = paxos->get_version();
+
+  if (paxosv == log_version) return true;
+  assert(paxosv >= log_version);
+
+  if (log_version == 0 && paxosv > 1) {
+    log_version = mon->store->get_int("log", "last_consumed");
+  }
+
+  // walk through incrementals
+  while (paxosv > log_version) {
+    bufferlist bl, new_bl;
+    LogEntry le;
+    bool success = paxos->read(log_version+1, bl);
+    assert(success);
+    bufferlist::iterator p = bl.begin();
+
+    le.decode(p);
+    dout(7) << "update_from_paxos applying incremental log " << log_version+1 <<  " " << le << dendl;
+
+    stringstream ss;
+    ss << le;
+    string s;
+    getline(ss, s);
+    new_bl.append(s);
+    new_bl.append("\n");
+    mon->store->append_bl_ss(new_bl, "out", NULL);
+
+    log_version++;
+  }
+
+  mon->store->put_int(paxosv, "log", "last_consumed");
+
   return true;
 }
 
@@ -166,12 +194,7 @@ bool LogMonitor::prepare_log(MLog *m)
        p != m->entries.end();
        p++) {
     dout(10) << " logging " << *p << dendl;
-    stringstream ss;
-    ss << *p;
-    string s;
-    getline(ss, s);
-    pending_inc.append(s);
-    pending_inc.append("\n");
+    (*p).encode(pending_inc);
   }
 
   paxos->wait_for_commit(new C_Log(this, m, m->get_orig_source_inst()));
diff --git a/src/mon/LogMonitor.h b/src/mon/LogMonitor.h
index 7d9eb7c91d7..05490eab899 100644
--- a/src/mon/LogMonitor.h
+++ b/src/mon/LogMonitor.h
@@ -31,6 +31,7 @@ class MLog;
 class LogMonitor : public PaxosService {
 private:
   bufferlist pending_inc;
+  version_t log_version;
 
   void create_initial();
   bool update_from_paxos();
@@ -60,7 +61,7 @@ private:
   bool prepare_command(MMonCommand *m);
 
  public:
-  LogMonitor(Monitor *mn, Paxos *p) : PaxosService(mn, p) { }
+  LogMonitor(Monitor *mn, Paxos *p) : PaxosService(mn, p), log_version(0) { }
   
   void tick();  // check state, take actions
 };
diff --git a/src/mon/MonitorStore.cc b/src/mon/MonitorStore.cc
index 063c20a277e..0d7837ffeca 100644
--- a/src/mon/MonitorStore.cc
+++ b/src/mon/MonitorStore.cc
@@ -238,7 +238,7 @@ int MonitorStore::get_bl_ss(bufferlist& bl, const char *a, const char *b)
   return len;
 }
 
-int MonitorStore::put_bl_ss(bufferlist& bl, const char *a, const char *b, bool sync)
+int MonitorStore::write_bl_ss(bufferlist& bl, const char *a, const char *b, bool append, bool sync)
 {
   char fn[200];
   sprintf(fn, "%s/%s", dir.c_str(), a);
@@ -251,8 +251,13 @@ int MonitorStore::put_bl_ss(bufferlist& bl, const char *a, const char *b, bool s
   }
   
   char tfn[200];
-  sprintf(tfn, "%s.new", fn);
-  int fd = ::open(tfn, O_WRONLY|O_CREAT, 0644);
+  int fd;
+  if (append) {
+    fd = ::open(fn, O_WRONLY|O_CREAT|O_APPEND, 0644);
+  } else {
+    sprintf(tfn, "%s.new", fn);
+    fd = ::open(tfn, O_WRONLY|O_CREAT, 0644);
+  }
   assert(fd >= 0);
   
   // write data
@@ -269,7 +274,10 @@ int MonitorStore::put_bl_ss(bufferlist& bl, const char *a, const char *b, bool s
   if (sync)
     ::fsync(fd);
   ::close(fd);
-  ::rename(tfn, fn);
+  if (!append) {
+    ::rename(tfn, fn);
+  }
 
   return 0;
 }
+
diff --git a/src/mon/MonitorStore.h b/src/mon/MonitorStore.h
index 01bae2bfe7e..1bf0a1c9102 100644
--- a/src/mon/MonitorStore.h
+++ b/src/mon/MonitorStore.h
@@ -24,6 +24,7 @@ class MonitorStore {
   string dir;
   int lock_fd;
 
+  int write_bl_ss(bufferlist& bl, const char *a, const char *b, bool append, bool sync=true);
 public:
   MonitorStore(const char *d) : dir(d) { }
   ~MonitorStore() { }
@@ -42,7 +43,12 @@ public:
   // ss and sn varieties.
   bool exists_bl_ss(const char *a, const char *b=0);
   int get_bl_ss(bufferlist& bl, const char *a, const char *b);
-  int put_bl_ss(bufferlist& bl, const char *a, const char *b, bool sync=true);
+  int put_bl_ss(bufferlist& bl, const char *a, const char *b, bool sync=true) {
+    return write_bl_ss(bl, a, b, false, sync);
+  }
+  int append_bl_ss(bufferlist& bl, const char *a, const char *b, bool sync=true) {
+    return write_bl_ss(bl, a, b, true, sync);
+  }
   bool exists_bl_sn(const char *a, version_t b) {
     char bs[20];
 #ifdef __LP64__