From: alfonsomthd <almartin@redhat.com>
Date: Tue, 18 Dec 2018 17:13:42 +0000 (+0100)
Subject: mgr/dashboard: Updated API pool tests
X-Git-Tag: v14.1.0~551^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5822effd1fcdf66cfb77827eb29c7e8bafcddeb3;p=ceph.git

mgr/dashboard: Updated API pool tests

Updated API pool tests
as stats are enabled by default when retrieving the pool list
since:
https://github.com/ceph/ceph/pull/25489

Fixes: https://tracker.ceph.com/issues/37704

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
---

diff --git a/qa/tasks/mgr/dashboard/test_pool.py b/qa/tasks/mgr/dashboard/test_pool.py
index 92276d228066..c0330ece6f59 100644
--- a/qa/tasks/mgr/dashboard/test_pool.py
+++ b/qa/tasks/mgr/dashboard/test_pool.py
@@ -127,7 +127,8 @@ class PoolTest(DashboardTestCase):
         self.assertEqual(len(cluster_pools), len(data))
         self.assertSchemaBody(JList(self.pool_schema))
         for pool in data:
-            self.assertNotIn('stats', pool)
+            self.assertIn('pg_status', pool)
+            self.assertIn('stats', pool)
             self.assertIn(pool['pool_name'], cluster_pools)
 
     def test_pool_list_attrs(self):
@@ -141,11 +142,12 @@ class PoolTest(DashboardTestCase):
             self.assertIn('type', pool)
             self.assertIn('flags', pool)
             self.assertNotIn('flags_names', pool)
+            self.assertNotIn('pg_status', pool)
             self.assertNotIn('stats', pool)
             self.assertIn(pool['pool_name'], cluster_pools)
 
-    def test_pool_list_stats(self):
-        data = self._get("/api/pool?stats=true")
+    def test_pool_list_without_stats(self):
+        data = self._get("/api/pool?stats=false")
         self.assertStatus(200)
 
         cluster_pools = self.ceph_cluster.mon_manager.list_pools()
@@ -155,7 +157,8 @@ class PoolTest(DashboardTestCase):
             self.assertIn('type', pool)
             self.assertIn('application_metadata', pool)
             self.assertIn('flags', pool)
-            self.assertIn('stats', pool)
+            self.assertNotIn('pg_status', pool)
+            self.assertNotIn('stats', pool)
             self.assertIn('flags_names', pool)
             self.assertIn(pool['pool_name'], cluster_pools)
 
@@ -166,6 +169,7 @@ class PoolTest(DashboardTestCase):
         self.assertEqual(pool['pool_name'], cluster_pools[0])
         self.assertIn('type', pool)
         self.assertIn('flags', pool)
+        self.assertNotIn('pg_status', pool)
         self.assertIn('stats', pool)
         self.assertNotIn('flags_names', pool)