From: Ilya Dryomov <idryomov@gmail.com>
Date: Tue, 19 Apr 2022 09:21:06 +0000 (+0200)
Subject: test/encoding/check-generated.sh: show diff if binary reencode check fails
X-Git-Tag: v18.0.0~1033^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=59d928a06c028bf381307001d2b68fa8545d8fc4;p=ceph.git

test/encoding/check-generated.sh: show diff if binary reencode check fails

Take bf0b161115aa ("test/encoding/check-generated.sh: show diff if cmp
fails") a bit further.  Suggesting "cmp $tmp1 $tmp2" isn't very helpful
since cmp would report just the mismatch offset.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/src/test/encoding/check-generated.sh b/src/test/encoding/check-generated.sh
index d89952710f88..2569bc1a5969 100755
--- a/src/test/encoding/check-generated.sh
+++ b/src/test/encoding/check-generated.sh
@@ -83,7 +83,7 @@ while read type; do
 		echo "**** $type test $n binary reencode check failed ****"
 		echo "   ceph-dencoder type $type select_test $n encode export $tmp1"
 		echo "   ceph-dencoder type $type select_test $n encode decode encode export $tmp2"
-		echo "   cmp $tmp1 $tmp2"
+		diff <(hexdump -C $tmp1) <(hexdump -C $tmp2)
 		failed=$(($failed + 1))
 	    fi
 	fi