From: Kefu Chai <kchai@redhat.com>
Date: Tue, 15 Dec 2020 08:47:20 +0000 (+0800)
Subject: crimson/osd: do not capture dup variable
X-Git-Tag: v16.1.0~260^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5b1b050750853136bdb3a7930c0511053fc695d7;p=ceph.git

crimson/osd: do not capture dup variable

first can be deduced by variable already captured, so store it as a
local variable. it's less expensive than storing it as a captured
variable.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc
index b61ea19fd8f..efb2ab530a7 100644
--- a/src/crimson/osd/replicated_recovery_backend.cc
+++ b/src/crimson/osd/replicated_recovery_backend.cc
@@ -648,8 +648,8 @@ seastar::future<bool> ReplicatedRecoveryBackend::_handle_pull_response(
         return crimson::osd::PG::load_obc_ertr::now();
       }).handle_error(crimson::ct_error::assert_all{});
   };
-  return prepare_waiter.then([this, first=pi.recovery_progress.first,
-			      &pi, &pop, t, response]() mutable {
+  return prepare_waiter.then([this, &pi, &pop, t, response]() mutable {
+    const bool first = pi.recovery_progress.first;
     pi.recovery_progress = pop.after_progress;
     logger().debug("new recovery_info {}, new progress {}",
 		   pi.recovery_info, pi.recovery_progress);