From: Sage Weil <sage@redhat.com>
Date: Tue, 4 Apr 2017 21:33:17 +0000 (-0400)
Subject: common/perf_counters: replace suppress_nicks with prio adjustment
X-Git-Tag: v12.0.3~71^2~18
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5b743f37db70cd0f334b6140384eef4fe1a5ffc8;p=ceph.git

common/perf_counters: replace suppress_nicks with prio adjustment

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/common/perf_counters.cc b/src/common/perf_counters.cc
index 404b39810e18..8602e2b8ab24 100644
--- a/src/common/perf_counters.cc
+++ b/src/common/perf_counters.cc
@@ -378,13 +378,16 @@ void PerfCounters::dump_formatted_generic(Formatter *f, bool schema,
         f->dump_string("description", "");
       }
 
-      if (d->nick != NULL && !suppress_nicks) {
+      if (d->nick != NULL) {
         f->dump_string("nick", d->nick);
       } else {
         f->dump_string("nick", "");
       }
       if (d->prio) {
-	f->dump_int("priority", d->prio);
+	int p = std::max(std::min(d->prio + prio_adjust,
+				  (int)PerfCountersBuilder::PRIO_CRITICAL),
+			 0);
+	f->dump_int("priority", p);
       }
       f->close_section();
     } else {
diff --git a/src/common/perf_counters.h b/src/common/perf_counters.h
index 516667d18874..19c01e3d08b6 100644
--- a/src/common/perf_counters.h
+++ b/src/common/perf_counters.h
@@ -182,8 +182,9 @@ public:
     m_name = s;
   }
 
-  void set_suppress_nicks(bool b) {
-    suppress_nicks = b;
+  /// adjust priority values by some value
+  void set_prio_adjust(int p) {
+    prio_adjust = p;
   }
 
 private:
@@ -202,7 +203,7 @@ private:
   std::string m_name;
   const std::string m_lock_name;
 
-  bool suppress_nicks = false;
+  int prio_adjust = 0;
 
   /** Protects m_data */
   mutable Mutex m_lock;
diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index ead8f35b13d9..baf0939b18ab 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -514,8 +514,8 @@ void OSDService::init()
   objecter_finisher.start();
   objecter->set_client_incarnation(0);
 
-  // exclude objecter from daemonperf output
-  objecter->get_logger()->set_suppress_nicks(true);
+  // deprioritize objecter in daemonperf output
+  objecter->get_logger()->set_prio_adjust(-3);
 
   watch_timer.init();
   agent_timer.init();