From: Jason Dillaman <dillaman@redhat.com>
Date: Mon, 14 Sep 2020 18:28:40 +0000 (-0400)
Subject: osdc/Objecter: fix list-snaps op implementation under neorados
X-Git-Tag: v16.1.0~961^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5bb9c5ecc7cb2f6492d0b49c6ac073d8608c1301;p=ceph.git

osdc/Objecter: fix list-snaps op implementation under neorados

The snapshot sequence for the CloneInfo structs was never populated
which resulted in a corrupt SnapSet.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
---

diff --git a/src/osdc/Objecter.h b/src/osdc/Objecter.h
index 17665fe60f304..c30fb20a8a3aa 100644
--- a/src/osdc/Objecter.h
+++ b/src/osdc/Objecter.h
@@ -811,7 +811,7 @@ struct ObjectOperation {
 	      clone.cloneid = std::move(c.cloneid);
 	      clone.snaps.reserve(c.snaps.size());
 	      std::move(c.snaps.begin(), c.snaps.end(),
-			clone.snaps.end());
+			std::back_inserter(clone.snaps));
 	      clone.overlap = c.overlap;
 	      clone.size = c.size;
 	      neosnaps->clones.push_back(std::move(clone));