From: Sage Weil <sage@inktank.com>
Date: Thu, 14 Feb 2013 01:30:19 +0000 (-0800)
Subject: udev: trigger ceph-disk-activate directly from udev
X-Git-Tag: v0.58~51^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5bd85ee5aa31bfd1f4f0e434f08c2a19414358ef;p=ceph.git

udev: trigger ceph-disk-activate directly from udev

There is no need to depend on upstart for this.

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/Makefile.am b/Makefile.am
index 3f4231438ad6..adeb4e577289 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -9,7 +9,8 @@ EXTRA_DIST += \
 	src/test/run-cli-tests-maybe-unset-ccache \
 	src/test/cli \
 	src/test/downloads \
-	udev/50-rbd.rules
+	udev/50-rbd.rules \
+	udev/95-ceph-osd.rules
 
 
 all-local:
diff --git a/ceph.spec.in b/ceph.spec.in
index 23451ab27202..38982bf99a8d 100644
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -295,6 +295,7 @@ mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/ceph/
 
 # udev rules
 install -D -m 644 udev/50-rbd.rules $RPM_BUILD_ROOT/lib/udev/rules.d/50-rbd.rules
+install -D -m 644 udev/95-ceph-osd.rules $RPM_BUILD_ROOT/lib/udev/rules.d/95-ceph-osd.rules
 
 %clean
 rm -rf $RPM_BUILD_ROOT
@@ -397,6 +398,7 @@ fi
 /sbin/ceph-disk-activate
 /sbin/ceph-disk-prepare
 /sbin/ceph-create-keys
+/lib/udev/rules.d/95-ceph-osd.rules
 
 #################################################################################
 %files fuse
diff --git a/debian/ceph.install b/debian/ceph.install
index da097b24c860..fb70d9b93807 100644
--- a/debian/ceph.install
+++ b/debian/ceph.install
@@ -24,3 +24,4 @@ usr/share/man/man8/monmaptool.8
 usr/share/man/man8/ceph-clsinfo.8
 usr/share/man/man8/ceph-debugpack.8
 etc/bash_completion.d/ceph
+lib/udev/rules.d/95-ceph-osd.rules
diff --git a/debian/rules b/debian/rules
index 39080a4edf34..9715b9f673c1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -91,6 +91,7 @@ install: build
 	$(MAKE) DESTDIR=$(DESTDIR) install
 	sed -i "/dependency_libs/ s/'.*'/''/" `find . -name '*.la'`
 	install -D -m 644 udev/50-rbd.rules $(DESTDIR)/lib/udev/rules.d/50-rbd.rules
+	install -D -m 644 udev/95-ceph-osd.rules $(DESTDIR)/lib/udev/rules.d/95-ceph-osd.rules
 
 # Add here commands to install the package into debian/testpack.
 # Build architecture-independent files here.
diff --git a/src/Makefile.am b/src/Makefile.am
index 4d006ce47583..f19ff51d4c76 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1115,7 +1115,6 @@ EXTRA_DIST += \
 	$(srcdir)/upstart/ceph-osd.conf \
 	$(srcdir)/upstart/ceph-osd-all.conf \
 	$(srcdir)/upstart/ceph-osd-all-starter.conf \
-	$(srcdir)/upstart/ceph-osd-activate.conf \
 	$(srcdir)/upstart/ceph-mds.conf \
 	$(srcdir)/upstart/ceph-mds-all.conf \
 	$(srcdir)/upstart/ceph-mds-all-starter.conf \
diff --git a/src/upstart/ceph-osd-activate.conf b/src/upstart/ceph-osd-activate.conf
deleted file mode 100644
index db88f018e029..000000000000
--- a/src/upstart/ceph-osd-activate.conf
+++ /dev/null
@@ -1,11 +0,0 @@
-description "Ceph OSD activate/hotplug"
-
-start on block-device-added \
-  DEVTYPE=partition \
-  ID_PART_ENTRY_TYPE=4fbd7e29-9d25-41b8-afd0-062c0ceff05d
-stop on runlevel [!2345]
-
-task
-instance $DEVNAME
-
-exec /usr/sbin/ceph-disk-activate --mark-init upstart --mount "$DEVNAME"
diff --git a/udev/95-ceph-osd.rules b/udev/95-ceph-osd.rules
new file mode 100644
index 000000000000..c3e05bb6ace1
--- /dev/null
+++ b/udev/95-ceph-osd.rules
@@ -0,0 +1,5 @@
+# activate ceph-tagged partitions
+ACTION=="add", SUBSYSTEM=="block", \
+  ENV{DEVTYPE}=="partition", \
+  ENV{ID_PART_ENTRY_TYPE}=="4fbd7e29-9d25-41b8-afd0-062c0ceff05d", \
+  RUN+="/usr/sbin/ceph-disk-activate --mount /dev/$name"