From: John Mulligan Date: Thu, 25 May 2023 23:17:02 +0000 (-0400) Subject: mgr/orchestrator: reformat ceph.deployment.service_spec import line X-Git-Tag: v19.0.0~926^2~8 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5cc6f0a147247799478556e01b397f3ee6599f2e;p=ceph.git mgr/orchestrator: reformat ceph.deployment.service_spec import line Quoting https://peps.python.org/pep-0008/#maximum-line-length ``` The preferred way of wrapping long lines is by using Python’s implied line continuation inside parentheses, brackets and braces. Long lines can be broken over multiple lines by wrapping expressions in parentheses. These should be used in preference to using a backslash for line continuation. ``` I also think it is much more readable and is similar to the style applied by automated code formatting tools like `black`. Signed-off-by: John Mulligan --- diff --git a/src/pybind/mgr/orchestrator/_interface.py b/src/pybind/mgr/orchestrator/_interface.py index 733e1cdcb5fa..829a46d1777b 100644 --- a/src/pybind/mgr/orchestrator/_interface.py +++ b/src/pybind/mgr/orchestrator/_interface.py @@ -30,8 +30,16 @@ except ImportError: import yaml from ceph.deployment import inventory -from ceph.deployment.service_spec import ServiceSpec, NFSServiceSpec, RGWSpec, \ - IscsiServiceSpec, IngressSpec, SNMPGatewaySpec, MDSSpec, TunedProfileSpec +from ceph.deployment.service_spec import ( + IngressSpec, + IscsiServiceSpec, + MDSSpec, + NFSServiceSpec, + RGWSpec, + SNMPGatewaySpec, + ServiceSpec, + TunedProfileSpec, +) from ceph.deployment.drive_group import DriveGroupSpec from ceph.deployment.hostspec import HostSpec, SpecValidationError from ceph.utils import datetime_to_str, str_to_datetime