From: Sage Weil <sage@redhat.com>
Date: Fri, 6 Mar 2020 01:57:56 +0000 (-0600)
Subject: mgr/orch: fix RGWSpec loading
X-Git-Tag: v15.1.1~83^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5d0df60596413bdbcc91a0b72b781e98afc20b14;p=ceph.git

mgr/orch: fix RGWSpec loading

Fixes ServiceSpec.from_json

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/pybind/mgr/orchestrator/_interface.py b/src/pybind/mgr/orchestrator/_interface.py
index 25627418aee..c448c634fe2 100644
--- a/src/pybind/mgr/orchestrator/_interface.py
+++ b/src/pybind/mgr/orchestrator/_interface.py
@@ -1667,14 +1667,20 @@ class RGWSpec(ServiceSpec):
 
     """
     def __init__(self,
-                 rgw_realm,  # type: str
-                 rgw_zone,  # type: str
+                 rgw_realm=None,  # type: Optional[str]
+                 rgw_zone=None,  # type: Optional[str]
+                 service_id=None, # type: Optional[str]
                  placement=None,
                  service_type='rgw',
                  rgw_frontend_port=None,  # type: Optional[int]
                  ):
         assert service_type == 'rgw'
-        super(RGWSpec, self).__init__('rgw', service_id=rgw_realm+'.'+rgw_zone, placement=placement)
+        if service_id:
+            (rgw_realm, rgw_zone) = service_id.split('.', 1)
+        else:
+            service_id = '%s.%s' % (rgw_realm, rgw_zone)
+        super(RGWSpec, self).__init__('rgw', service_id=service_id, placement=placement)
+
 
         self.rgw_realm = rgw_realm
         self.rgw_zone = rgw_zone