From: Prashant D <pdhange@redhat.com>
Date: Tue, 27 Sep 2022 02:40:45 +0000 (-0400)
Subject: mon: Fix condition to check for ceph version mismatch
X-Git-Tag: v18.1.0~718^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5dc0d6f7f299cc7af0c243ba67036b075f4b72af;p=ceph.git

mon: Fix condition to check for ceph version mismatch

MON fails to send MMgrUpdate to the MGR to update
DaemonState with correct metadata information due to
incorrect conditional check. Send MMgrUpdate to MGR
if we observe ceph version mismatch after an election
is over.

Fixes: https://tracker.ceph.com/issues/57678

Signed-off-by: Prashant D <pdhange@redhat.com>
---

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 0846fa0a8f00..8e48bf0c2541 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -2975,7 +2975,7 @@ void Monitor::update_pending_metadata()
   const std::string current_version = mon_metadata[rank]["ceph_version_short"];
   const std::string pending_version = metadata["ceph_version_short"];
 
-  if (current_version.compare(0, version_size, pending_version) < 0) {
+  if (current_version.compare(0, version_size, pending_version) != 0) {
     mgr_client.update_daemon_metadata("mon", name, metadata);
   }
 }