From: amitkuma <amitkuma@redhat.com>
Date: Thu, 7 Dec 2017 15:49:58 +0000 (+0530)
Subject: mds,rgw: Initializing standby_reply, sync_tracer
X-Git-Tag: v13.0.2~718^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5dc879e1e850fa118f3dfcca9caacd5180ad226e;p=ceph.git

mds,rgw: Initializing standby_reply, sync_tracer

Fixes te coveity issue:

** 1396192 Uninitialized scalar field
CID 1396192 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member standby_replay is
not initialized in this constructor nor in any functions that it calls.

** 717382 Uninitialized pointer field
CID 717382 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member sync_tracer is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
---

diff --git a/src/mds/Beacon.h b/src/mds/Beacon.h
index 201804def072..8b5ac30b6f4d 100644
--- a/src/mds/Beacon.h
+++ b/src/mds/Beacon.h
@@ -87,7 +87,7 @@ private:
   mds_rank_t standby_for_rank;
   std::string standby_for_name;
   fs_cluster_id_t standby_for_fscid;
-  bool standby_replay;
+  bool standby_replay = false;
   MDSMap::DaemonState want_state;
 
   // Internal beacon state
diff --git a/src/rgw/rgw_rados.h b/src/rgw/rgw_rados.h
index 97a62c65dd30..ec1b4b6a1357 100644
--- a/src/rgw/rgw_rados.h
+++ b/src/rgw/rgw_rados.h
@@ -2285,7 +2285,7 @@ class RGWRados
   RGWMetaNotifier *meta_notifier;
   RGWDataNotifier *data_notifier;
   RGWMetaSyncProcessorThread *meta_sync_processor_thread;
-  RGWSyncTraceManager *sync_tracer;
+  RGWSyncTraceManager *sync_tracer = nullptr;
   map<string, RGWDataSyncProcessorThread *> data_sync_processor_threads;
 
   boost::optional<rgw::BucketTrimManager> bucket_trim;