From: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
Date: Mon, 23 Jun 2025 20:23:05 +0000 (+0300)
Subject: mgr/dashboard: migrate nvmeof pr #1238 to new cli
X-Git-Tag: v20.0.0-pre.ibm~29^2~6
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5df9b31f92480ca3b1b1e50f9756a09da18b27a3;p=ceph-ci.git

mgr/dashboard: migrate nvmeof pr #1238 to new cli

Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 4c6304e7ff1e2df469b7f6e26337e5cfa13bc4b2)
---

diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py
index a0e1fb9404f..1111523ae09 100644
--- a/src/pybind/mgr/dashboard/controllers/nvmeof.py
+++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py
@@ -604,7 +604,9 @@ else:
         @NvmeofCLICommand("nvmeof connection list", model.ConnectionList)
         @convert_to_model(model.ConnectionList)
         @handle_nvmeof_error
-        def list(self, nqn: str, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+        def list(self, nqn: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+            if not nqn:
+                nqn = '*'
             return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_connections(
                 NVMeoFClient.pb2.list_connections_req(subsystem=nqn)
             )
diff --git a/src/pybind/mgr/dashboard/model/nvmeof.py b/src/pybind/mgr/dashboard/model/nvmeof.py
index 0c3cf4c7907..330265879c4 100644
--- a/src/pybind/mgr/dashboard/model/nvmeof.py
+++ b/src/pybind/mgr/dashboard/model/nvmeof.py
@@ -88,6 +88,7 @@ class Connection(NamedTuple):
     connected: bool
     qpairs_count: int
     controller_id: int
+    subsystem: Optional[str]
 
 
 class ConnectionList(NamedTuple):