From: Kefu Chai <kchai@redhat.com>
Date: Wed, 19 May 2021 04:26:15 +0000 (+0800)
Subject: crimson/os: move ctor of SeaStore into .cc
X-Git-Tag: v17.1.0~1899^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5ec16ca839e438fad6dada1e06d827feb7065e03;p=ceph.git

crimson/os: move ctor of SeaStore into .cc

so the ctor and dtor are colocated in the same file. for better
readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/os/seastore/seastore.cc b/src/crimson/os/seastore/seastore.cc
index b7823c25ce7e..d2b39bb0e0b6 100644
--- a/src/crimson/os/seastore/seastore.cc
+++ b/src/crimson/os/seastore/seastore.cc
@@ -29,6 +29,20 @@ using crimson::common::local_conf;
 
 namespace crimson::os::seastore {
 
+SeaStore::SeaStore(
+  SegmentManagerRef sm,
+  TransactionManagerRef tm,
+  CollectionManagerRef cm,
+  OnodeManagerRef om)
+  : segment_manager(std::move(sm)),
+    transaction_manager(std::move(tm)),
+    collection_manager(std::move(cm)),
+    onode_manager(std::move(om)),
+    perf_service(std::move(p_service))
+{
+  perf_service->add_to_collection();
+}
+
 SeaStore::~SeaStore() {
   perf_service->remove_from_collection();
 }
diff --git a/src/crimson/os/seastore/seastore.h b/src/crimson/os/seastore/seastore.h
index f340e4015670..30f23de61616 100644
--- a/src/crimson/os/seastore/seastore.h
+++ b/src/crimson/os/seastore/seastore.h
@@ -39,15 +39,7 @@ public:
     TransactionManagerRef tm,
     CollectionManagerRef cm,
     OnodeManagerRef om,
-    PerfServiceRef p_service
-  ) : segment_manager(std::move(sm)),
-      transaction_manager(std::move(tm)),
-      collection_manager(std::move(cm)),
-      onode_manager(std::move(om)),
-      perf_service(std::move(p_service)) {
-    perf_service->add_to_collection();
-  }
-
+    PerfServiceRef p_service);
   ~SeaStore();
     
   seastar::future<> stop() final;