From: Stephan Müller <smueller@suse.com>
Date: Wed, 9 Jan 2019 12:49:14 +0000 (+0100)
Subject: mgr/dashboard: RbdMirroringService test suite fails in dev mode
X-Git-Tag: v14.1.0~378^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5f977920a6147aefd78caf1535f8cda9ca5df49b;p=ceph.git

mgr/dashboard: RbdMirroringService test suite fails in dev mode

If you have set DEV in unit-test-configuration.ts to true, in order to
run all unit tests much faster, the unit test suite of rbd mirroring
service fails.

The reason is, that it's expecting a call, that is triggered inside the
constructor, which is only done once in for the copy used in the fast
testing mode (if it would be done on within ngOnInit this wouldn't be a
problem).

Fixes: http://tracker.ceph.com/issues/37841
Signed-off-by: Stephan Müller <smueller@suse.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd-mirroring.service.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd-mirroring.service.spec.ts
index 905c5110bdaf..6432e187ce33 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd-mirroring.service.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd-mirroring.service.spec.ts
@@ -19,10 +19,13 @@ describe('RbdMirroringService', () => {
     }
   };
 
-  configureTestBed({
-    providers: [RbdMirroringService],
-    imports: [HttpClientTestingModule]
-  });
+  configureTestBed(
+    {
+      providers: [RbdMirroringService],
+      imports: [HttpClientTestingModule]
+    },
+    true
+  );
 
   beforeEach(() => {
     service = TestBed.get(RbdMirroringService);