From: David Galloway Date: Thu, 9 Jul 2026 16:28:45 +0000 (-0400) Subject: ceph-release-pipeline: pass boolean parameters as booleans X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=5feb069db32f4835a34b7ddb2102aed54a928451;p=ceph-build.git ceph-release-pipeline: pass boolean parameters as booleans The ceph-dev-pipeline and second ceph-tag invocations passed env values (strings) straight to booleanParam, unlike the first ceph-tag invocation which converts with .toBoolean(). Downstream now compares params.THROWAWAY == false strictly, so make sure the values arrive as actual booleans. Signed-off-by: David Galloway --- diff --git a/ceph-release-pipeline/build/Jenkinsfile b/ceph-release-pipeline/build/Jenkinsfile index 9af3331f3..b064d126d 100644 --- a/ceph-release-pipeline/build/Jenkinsfile +++ b/ceph-release-pipeline/build/Jenkinsfile @@ -59,8 +59,8 @@ pipeline { string(name: "ARCHS", value: env.ARCHS), string(name: "FLAVORS", value: 'default'), booleanParam(name: "CI_COMPILE", value: true), - booleanParam(name: "THROWAWAY", value: env.THROWAWAY), - booleanParam(name: "FORCE", value: env.FORCE), + booleanParam(name: "THROWAWAY", value: env.THROWAWAY?.toBoolean()), + booleanParam(name: "FORCE", value: env.FORCE?.toBoolean()), string(name: 'FLAVOR', value: 'default'), // Release containers are built manually from signed packages so we don't need to build them here booleanParam(name: 'CI_CONTAINER', value: false), @@ -85,10 +85,10 @@ pipeline { parameters: [ string(name: 'VERSION', value: env.VERSION ?: ''), string(name: 'BRANCH', value: env.BRANCH ?: ''), - booleanParam(name: 'FORCE_VERSION', value: env.FORCE_VERSION), + booleanParam(name: 'FORCE_VERSION', value: env.FORCE_VERSION?.toBoolean()), string(name: 'RELEASE_TYPE', value: env.RELEASE_TYPE ?: ''), booleanParam(name: 'RELEASE_BUILD', value: true), - booleanParam(name: 'TAG', value: env.TAG), + booleanParam(name: 'TAG', value: env.TAG?.toBoolean()), string(name: 'TAG_PHASE', value: 'push') ], )