From: Nitzan Mordechai <nmordech@redhat.com>
Date: Mon, 20 Jan 2025 13:35:06 +0000 (+0000)
Subject: workunits/rados/test-clay-profiles: Add tests for CLAY profile configurations
X-Git-Tag: testing/wip-vshankar-testing-20250407.170244-debug~32^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=600fcd3ce73b2324d2c161829db0ec9d706902a2;p=ceph-ci.git

workunits/rados/test-clay-profiles: Add tests for CLAY profile configurations

Introduced a test script to validate boundary cases and invalid configurations
for CLAY erasure code profiles.
Scenarios include:
  - Testing valid and invalid ranges for decoding threshold (`d`).
  - Verifying total chunk limits (`k + m + nu <= 254`).
  - Handling invalid parameter combinations for `k`, `m`, and unsupported techniques.
Ensures robustness and correctness of the CLAY profile creation logic.

This script helps identify issues with configuration validation and enforces documented constraints.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
---

diff --git a/qa/workunits/rados/test-clay-profiles.sh b/qa/workunits/rados/test-clay-profiles.sh
new file mode 100755
index 00000000000..db045dc0474
--- /dev/null
+++ b/qa/workunits/rados/test-clay-profiles.sh
@@ -0,0 +1,84 @@
+#!/bin/bash
+
+# Ceph CLI commands and validation script for CLAY profile corner cases
+
+# Variables
+PROFILE_NAME="test_clay_profile"
+
+expect_false()
+{
+  if "$@"; then
+    echo "+++++ expected failure, but got success! cmd: $@"
+    exit 1
+  else
+    echo "+++++ expected failure"
+    echo -e "\n\n"
+  fi
+}
+
+expect_true()
+{
+  if "$@"; then
+    ceph osd erasure-code-profile rm "$PROFILE_NAME" > /dev/null 2>&1 || true
+    echo -e "\n\n"
+  else
+    echo "+++++ function returned non-zero, we failed"
+    exit 1
+  fi
+}
+
+ecp_create_test() {
+  local k=$1
+  local m=$2
+  local d=$3
+  local description=$4
+
+  echo "Testing with k=$k, m=$m, d=$d: $description"
+  ceph osd erasure-code-profile set "$PROFILE_NAME" \
+    plugin=clay \
+    k=$k \
+    m=$m \
+    d=$d
+  local result=$?
+  if [ $result -ne 0 ]; then
+    echo "Failed to create profile with k=$k, m=$m, d=$d"
+  fi
+  return $result
+}
+
+# 1. Boundary Values for d
+expect_false ecp_create_test 3 2 3 "Lower boundary (should fail)"
+expect_true ecp_create_test 3 2 4 "Exact lower bound (should succeed)"
+expect_false ecp_create_test 3 2 5 "Exact upper bound (should failed)"
+
+# 2. Invalid d Values
+expect_false ecp_create_test 3 2 -1 "Negative d (should fail)"
+expect_false ecp_create_test 3 2 0 "Zero d (should fail)"
+expect_false ecp_create_test 3 2 10 "Unreasonably large d (should fail)"
+
+# 3. Invalid Total Number of Chunks
+expect_false ecp_create_test 250 5 255 "Exceeds total chunk limit (should fail)"
+
+# 4. Valid but Edge Cases
+expect_false ecp_create_test 1 1 2 "Minimum viable configuration (should fail)"
+expect_false ecp_create_test 253 1 252 "Maximum viable configuration (should fail)"
+expect_true ecp_create_test 10 2 11 "Highly imbalanced configuration (should succeed)"
+
+# 5. Invalid Techniques expected to fail
+expect_false ceph osd erasure-code-profile set "$PROFILE_NAME" \
+  plugin=clay \
+  k=3 \
+  m=2 \
+  d=4 \
+  scalar_mds=isa \
+  technique=liber8tion
+
+# 6. Mixed Valid/Invalid Configurations
+expect_false ecp_create_test 3 2 0 "Invalid d with valid k and m (should fail)"
+expect_false ecp_create_test 0 2 3 "Valid d with invalid k (should fail)"
+expect_false ecp_create_test 3 0 4 "Valid d with invalid m (should fail)"
+
+
+expect_true ecp_create_test 10 5 13 "Valid configuration with padding (should succeed)"
+expect_false ecp_create_test 250 4 253 "Invalid configuration exceeding chunk limit (should fail)"
+expect_true ecp_create_test 12 3 14 "Configuration without padding (should succeed)"