From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Sat, 1 Mar 2014 12:45:53 +0000 (+0100)
Subject: Objecter::recalc_op_target: fix uninitialized scalar variable
X-Git-Tag: v0.78~108^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=605e645026487519d4195358330832b3369b531d;p=ceph.git

Objecter::recalc_op_target: fix uninitialized scalar variable

CID 1160848 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value "best".

Init 'best' with -1 (from the code logic it will be set at least to 0)
to silence coverity.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/osdc/Objecter.cc b/src/osdc/Objecter.cc
index 7f64b00eca1..a2954662605 100644
--- a/src/osdc/Objecter.cc
+++ b/src/osdc/Objecter.cc
@@ -1495,7 +1495,7 @@ int Objecter::recalc_op_target(Op *op)
 		 acting.size() > 1) {
 	// look for a local replica.  prefer the primary if the
 	// distance is the same.
-	int best;
+	int best = -1;
 	int best_locality;
 	for (unsigned i = 0; i < acting.size(); ++i) {
 	  int locality = osdmap->crush->get_common_ancestor_distance(