From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Fri, 13 Oct 2017 18:43:43 +0000 (+0200)
Subject: librbd.cc: fix usage of unsigned var
X-Git-Tag: v13.0.1~358^2~16
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=606768e8b2cbd95e3d43e5e9e5e5cc6c75561a1a;p=ceph.git

librbd.cc: fix usage of unsigned var

Fix for:

[src/librbd/librbd.cc:3578]: (style) Checking if unsigned variable
 'data_len' is less than zero.
[src/librbd/librbd.cc:3799]: (style) Checking if unsigned variable
 'data_len' is less than zero.
[src/librbd/librbd.cc:3576]: (style) Checking if unsigned variable
 'data_len' is less than zero.
[src/librbd/librbd.cc:3796]: (style) Checking if unsigned variable
 'data_len' is less than zero.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/librbd/librbd.cc b/src/librbd/librbd.cc
index e65330c2580..0004a2a87a0 100644
--- a/src/librbd/librbd.cc
+++ b/src/librbd/librbd.cc
@@ -3573,9 +3573,9 @@ extern "C" ssize_t rbd_writesame(rbd_image_t image, uint64_t ofs, size_t len,
 {
   librbd::ImageCtx *ictx = (librbd::ImageCtx *)image;
   tracepoint(librbd, writesame_enter, ictx, ictx->name.c_str(), ictx->snap_name.c_str(),
-             ictx->read_only, ofs, len, data_len <= 0 ? NULL : buf, data_len, op_flags);
+             ictx->read_only, ofs, len, data_len == 0 ? NULL : buf, data_len, op_flags);
 
-  if (data_len <= 0 || len % data_len) {
+  if (data_len == 0 || len % data_len) {
     tracepoint(librbd, writesame_exit, -EINVAL);
     return -EINVAL;
   }
@@ -3793,10 +3793,10 @@ extern "C" int rbd_aio_writesame(rbd_image_t image, uint64_t off, size_t len,
   librbd::ImageCtx *ictx = (librbd::ImageCtx *)image;
   librbd::RBD::AioCompletion *comp = (librbd::RBD::AioCompletion *)c;
   tracepoint(librbd, aio_writesame_enter, ictx, ictx->name.c_str(), ictx->snap_name.c_str(),
-             ictx->read_only, off, len, data_len <= 0 ? NULL : buf, data_len, comp->pc,
+             ictx->read_only, off, len, data_len == 0 ? NULL : buf, data_len, comp->pc,
              op_flags);
 
-  if (data_len <= 0 || len % data_len) {
+  if (data_len == 0 || len % data_len) {
     tracepoint(librbd, aio_writesame_exit, -EINVAL);
     return -EINVAL;
   }