From: Rishabh Dave Date: Sat, 29 Mar 2025 11:21:31 +0000 (+0530) Subject: mgr/vol: improve dump() of trash.py X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=60a7baafc913ebd5f9c52cfe1e62efc776f52abd;p=ceph-ci.git mgr/vol: improve dump() of trash.py "path" doesn't clearly specify what path that variable contains. Rename it to something more specific and more descriptive based on its contents. Signed-off-by: Rishabh Dave --- diff --git a/src/pybind/mgr/volumes/fs/operations/trash.py b/src/pybind/mgr/volumes/fs/operations/trash.py index 29d155f7a66..80ff86a8dc1 100644 --- a/src/pybind/mgr/volumes/fs/operations/trash.py +++ b/src/pybind/mgr/volumes/fs/operations/trash.py @@ -76,15 +76,15 @@ class Trash(GroupTemplate): except cephfs.Error as e: raise VolumeException(-e.args[0], e.args[1]) - def dump(self, path): + def dump(self, SRC_PATH): """ move an filesystem entity to trash can. - :praram path: the filesystem path to be moved + :praram SRC_PATH: the filesystem SRC_PATH to be moved :return: None """ try: - self.fs.rename(path, self.unique_trash_path) + self.fs.rename(SRC_PATH, self.unique_trash_path) except cephfs.Error as e: raise VolumeException(-e.args[0], e.args[1])