From: Dan Mick <dan.mick@inktank.com>
Date: Thu, 17 Jan 2013 19:32:03 +0000 (-0800)
Subject: crushtool: warn usefully about missing output spec
X-Git-Tag: v0.57~178
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=60db6e3e394df1e4110eefa5951657b648b02006;p=ceph.git

crushtool: warn usefully about missing output spec

When running with --test, you must request output to CSV files or
specific types of output to --show-X; make the error message
clarify what the tool wants.

Fixes: #3827
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/crushtool.cc b/src/crushtool.cc
index 6584be54d5a8..3cbd915a3215 100644
--- a/src/crushtool.cc
+++ b/src/crushtool.cc
@@ -413,7 +413,7 @@ int main(int argc, const char **argv)
   }
 
   if (test && !display && !write_to_file) {
-    cerr << "WARNING: no output selected (via -o <filename>)" << std::endl;
+    cerr << "WARNING: no output selected; use --output-csv or --show-X" << std::endl;
     exit(EXIT_FAILURE);
   }