From: Igor Golikov <igolikov@redhat.com>
Date: Tue, 10 Feb 2026 08:10:09 +0000 (+0000)
Subject: mds: add comment re: rank0 perf metrics collection
X-Git-Tag: testing/wip-vshankar-testing-20260222.101816~3^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=61e5ddbb1dd68f82cbf44d2be0e89d030e9aa42b;p=ceph-ci.git

mds: add comment re: rank0 perf metrics collection

Signed-off-by: Igor Golikov <igolikov@redhat.com>
---

diff --git a/src/mds/MetricsHandler.cc b/src/mds/MetricsHandler.cc
index 61f5b88771a..c309eb1fd1d 100644
--- a/src/mds/MetricsHandler.cc
+++ b/src/mds/MetricsHandler.cc
@@ -64,6 +64,9 @@ Dispatcher::dispatch_result_t MetricsHandler::ms_dispatch2(const ref_t<Message>
 void MetricsHandler::init() {
   dout(10) << dendl;
 
+  // Create local perf counters for non-rank0 MDS only. Rank0's perf counters
+  // are created by MetricAggregator::update_rank_perf_metrics() to avoid
+  // duplicate counters (MetricAggregator creates counters for all ranks).
   if (mds->get_nodeid() != 0 && !rank_perf_counters) {
     std::string labels = ceph::perf_counters::key_create(
       "mds_rank_perf",