From: Sage Weil <sage@redhat.com>
Date: Tue, 26 Jun 2018 02:08:48 +0000 (-0500)
Subject: osd/PG: do not assume delete event means found_missing
X-Git-Tag: v13.2.1~86^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6475c9d55a0cb79d7e906067d894dec20b0639d5;p=ceph.git

osd/PG: do not assume delete event means found_missing

This condition was introduced in 3a9d056d843bcafd26d78950b84e2844f8a3a9a1
as part of the missing deletes series, without a clear motivation.  The
best guess is that it was either compensating for some other unfound bug
or simply being a bit overaggressive.

The problem is that it triggers a notify being sent to the sender, or
restarts recovery, both of which are overreactions.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 81d918d449f0211c8eac262e700930473f6e98a3)
---

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index f8fdc05e483e..43c0ec28865b 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -665,7 +665,6 @@ bool PG::MissingLoc::add_source_info(
     if (p->second.is_delete()) {
       ldout(pg->cct, 10) << __func__ << " " << soid
 			 << " delete, ignoring source" << dendl;
-      found_missing = true;
       continue;
     }
     if (oinfo.last_update < need) {