From: Adam Retter Date: Tue, 11 Dec 2018 19:04:39 +0000 (-0800) Subject: RocksJava must compile on JDK7 (#4768) X-Git-Tag: v5.18.4~2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=64dbc7813e8d5419d2802750e7749b1fa979819b;p=rocksdb.git RocksJava must compile on JDK7 (#4768) Summary: Fixes some RocksJava regressions recently introduced, whereby RocksJava would not build on JDK 7. These should have been visible on Travis-CI! Pull Request resolved: https://github.com/facebook/rocksdb/pull/4768 Differential Revision: D13418173 Pulled By: sagar0 fbshipit-source-id: 57bf223188887f84d9e072031af2e0d2c8a69c30 --- diff --git a/java/src/main/java/org/rocksdb/MemoryUsageType.java b/java/src/main/java/org/rocksdb/MemoryUsageType.java index 3523cd0ee..6010ce7af 100644 --- a/java/src/main/java/org/rocksdb/MemoryUsageType.java +++ b/java/src/main/java/org/rocksdb/MemoryUsageType.java @@ -54,9 +54,9 @@ public enum MemoryUsageType { * cannot be found */ public static MemoryUsageType getMemoryUsageType(final byte byteIdentifier) { - for (final MemoryUsageType MemoryUsageType : MemoryUsageType.values()) { - if (MemoryUsageType.getValue() == byteIdentifier) { - return MemoryUsageType; + for (final MemoryUsageType memoryUsageType : MemoryUsageType.values()) { + if (memoryUsageType.getValue() == byteIdentifier) { + return memoryUsageType; } } @@ -64,7 +64,7 @@ public enum MemoryUsageType { "Illegal value provided for MemoryUsageType."); } - private MemoryUsageType(byte value) { + MemoryUsageType(byte value) { value_ = value; } diff --git a/java/src/test/java/org/rocksdb/MergeTest.java b/java/src/test/java/org/rocksdb/MergeTest.java index b2ec62635..554698476 100644 --- a/java/src/test/java/org/rocksdb/MergeTest.java +++ b/java/src/test/java/org/rocksdb/MergeTest.java @@ -46,13 +46,13 @@ public class MergeTest { } private byte[] longToByteArray(long l) { - ByteBuffer buf = ByteBuffer.allocate(Long.BYTES); + ByteBuffer buf = ByteBuffer.allocate(Long.SIZE / Byte.SIZE); buf.putLong(l); return buf.array(); } private long longFromByteArray(byte[] a) { - ByteBuffer buf = ByteBuffer.allocate(Long.BYTES); + ByteBuffer buf = ByteBuffer.allocate(Long.SIZE / Byte.SIZE); buf.put(a); buf.flip(); return buf.getLong();