From: Anoop C S Date: Mon, 8 Jan 2024 11:45:26 +0000 (+0530) Subject: client: Fix parsing of xattr namespace in removexattr X-Git-Tag: v20.0.0~2572^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=655aedf605e8b5bc99976499ae5bdb8d11aa4a93;p=ceph.git client: Fix parsing of xattr namespace in removexattr To match the kernel ceph client, as mentioned by the inline comments, remove the comparison with "system." xattr namespace in removexattr() code path. This is in preparation to handle the case where POSIX ACL xattrs are treated differently by kernel during removexattr operation. ref: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ceph/xattr.c#n21 Signed-off-by: Anoop C S --- diff --git a/src/client/Client.cc b/src/client/Client.cc index 195738efc87d..9479ebfa2170 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -14069,7 +14069,6 @@ int Client::_removexattr(Inode *in, const char *name, const UserPerm& perms) // same xattrs supported by kernel client if (strncmp(name, "user.", 5) && - strncmp(name, "system.", 7) && strncmp(name, "security.", 9) && strncmp(name, "trusted.", 8) && strncmp(name, "ceph.", 5))