From: Kefu Chai <kchai@redhat.com>
Date: Mon, 11 Feb 2019 15:23:08 +0000 (+0800)
Subject: test/crimson: should not capture temporary variables
X-Git-Tag: v14.1.0~124^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6565b406380d2b0364c33dc75d1bc9e63ed27cdc;p=ceph.git

test/crimson: should not capture temporary variables

otherwise, we are passing dangling pointers down to
`app_template::run()`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/test/crimson/test_alien_echo.cc b/src/test/crimson/test_alien_echo.cc
index ad91f74078a33..2000b590ad34d 100644
--- a/src/test/crimson/test_alien_echo.cc
+++ b/src/test/crimson/test_alien_echo.cc
@@ -417,7 +417,7 @@ int main(int argc, char** argv)
     std::transform(begin(unrecognized_options),
                    end(unrecognized_options),
                    std::back_inserter(av),
-                   [](auto s) {
+                   [](auto& s) {
                      return const_cast<char*>(s.c_str());
                    });
     sc.run(app, av.size(), av.data());