From: Sage Weil <sage@redhat.com>
Date: Mon, 28 Nov 2016 19:26:21 +0000 (-0500)
Subject: os/ObjectStore: pass by ref to clone
X-Git-Tag: v11.1.0~120^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=65c6156563597cced9d581210dc6f1a6d752dcfa;p=ceph.git

os/ObjectStore: pass by ref to clone

CID 1395658 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
pass_by_value: Passing parameter noid of type ghobject_t (size 144 bytes) by value.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/os/ObjectStore.h b/src/os/ObjectStore.h
index 35e1026685c..3bbce755560 100644
--- a/src/os/ObjectStore.h
+++ b/src/os/ObjectStore.h
@@ -1156,7 +1156,8 @@ public:
      * The destination named object may already exist, in
      * which case its previous contents are discarded.
      */
-    void clone(const coll_t& cid, const ghobject_t& oid, ghobject_t noid) {
+    void clone(const coll_t& cid, const ghobject_t& oid,
+	       const ghobject_t& noid) {
       Op* _op = _get_next_op();
       _op->op = OP_CLONE;
       _op->cid = _get_coll_id(cid);