From: Mykola Golub <mgolub@mirantis.com>
Date: Sun, 2 Apr 2017 15:19:14 +0000 (+0200)
Subject: librbd: race between notify context completion and Notifier destroy
X-Git-Tag: v12.0.3~320^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=65e25de51ffa881ecdc203285d44067db94fb345;p=ceph.git

librbd: race between notify context completion and Notifier destroy

The assert "m_pending_aio_notifies == 0" could fail in the destructor.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
---

diff --git a/src/librbd/watcher/Notifier.cc b/src/librbd/watcher/Notifier.cc
index b899de223211..8575ec68244b 100644
--- a/src/librbd/watcher/Notifier.cc
+++ b/src/librbd/watcher/Notifier.cc
@@ -9,7 +9,8 @@
 
 #define dout_subsys ceph_subsys_rbd
 #undef dout_prefix
-#define dout_prefix *_dout << "librbd::object_watcher::Notifier: "
+#define dout_prefix *_dout << "librbd::watcher::Notifier: " \
+                           << this << " " << __func__ << ": "
 
 namespace librbd {
 namespace watcher {
@@ -63,8 +64,7 @@ void Notifier::notify(bufferlist &bl, NotifyResponse *response,
     Mutex::Locker aio_notify_locker(m_aio_notify_lock);
     ++m_pending_aio_notifies;
 
-    ldout(m_cct, 20) << __func__ << ": pending=" << m_pending_aio_notifies
-                     << dendl;
+    ldout(m_cct, 20) << "pending=" << m_pending_aio_notifies << dendl;
   }
 
   C_AioNotify *ctx = new C_AioNotify(this, response, on_finish);
@@ -75,22 +75,23 @@ void Notifier::notify(bufferlist &bl, NotifyResponse *response,
 }
 
 void Notifier::handle_notify(int r, Context *on_finish) {
-  if (on_finish != nullptr) {
-    m_work_queue->queue(on_finish, r);
-  }
+  ldout(m_cct, 20) << "r=" << r << dendl;
 
   Mutex::Locker aio_notify_locker(m_aio_notify_lock);
   assert(m_pending_aio_notifies > 0);
   --m_pending_aio_notifies;
 
-  ldout(m_cct, 20) << __func__ << ": pending=" << m_pending_aio_notifies
-                   << dendl;
+  ldout(m_cct, 20) << "pending=" << m_pending_aio_notifies << dendl;
   if (m_pending_aio_notifies == 0) {
     for (auto ctx : m_aio_notify_flush_ctxs) {
       m_work_queue->queue(ctx, 0);
     }
     m_aio_notify_flush_ctxs.clear();
   }
+
+  if (on_finish != nullptr) {
+    m_work_queue->queue(on_finish, r);
+  }
 }
 
 } // namespace watcher