From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Fri, 5 Oct 2018 11:41:38 +0000 (+0200)
Subject: ceph-ansible-syntax: remove capital letter check
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=66553c8ac7dce608ca2a348f4e3381e9ff4aa41a;p=ceph-build.git

ceph-ansible-syntax: remove capital letter check

Some PRs aren't passing the CI while it should.

It's making us maintaining a list of path and pattern to exclude.
IMHO, this test isn't needed and brings more issues than it is supposed to
solve.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
---

diff --git a/ceph-ansible-pr-syntax-check/build/build b/ceph-ansible-pr-syntax-check/build/build
index 371948382..2698e7eb9 100644
--- a/ceph-ansible-pr-syntax-check/build/build
+++ b/ceph-ansible-pr-syntax-check/build/build
@@ -50,7 +50,7 @@ function group_vars_check {
 function git_diff_to_head {
   # shellcheck disable=SC2154
   # ghprbTargetBranch variable comes from jenkins's injectedEnvVars
-  git diff origin/"${ghprbTargetBranch}"..HEAD -- . ':(exclude)roles/*/meta/*'
+  git diff origin/"${ghprbTargetBranch}"..HEAD
 }
 
 function match_file {
@@ -64,15 +64,6 @@ function test_sign_off {
   echo "Sign-off ok!" && return 0
 }
 
-function test_capital_letter {
-  if git_diff_to_head | grep -E '^[<>+].*- name:' | grep '[[:upper:]]'; then
-    echo "'- name:' statement must not contain any capital letters!"
-    echo "Remove any capital letters from task's name."
-    return 1
-  fi
-  echo "No capital letters found in task's name!" && return 0
-}
-
 function test_ceph_release_in_ceph_default {
   if match_file "roles/ceph-defaults/" | grep -E '^[<>+].*- ceph_release_num\[ceph_release\]'; then
     echo "Do not use statements like '- ceph_release_num[ceph_release]' in ceph-defaults role!"
@@ -91,5 +82,4 @@ syntax_check
 #ansible_lint
 group_vars_check
 test_sign_off
-test_capital_letter
 test_ceph_release_in_ceph_default