From: Alex Elder <aelder@sgi.com>
Date: Thu, 6 May 2010 17:26:07 +0000 (+0000)
Subject: xfstests: honor comments in the test group file
X-Git-Tag: v1.1.0~165
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6728bbddc8ecc60334594eaee3e5239a7e3802c8;p=xfstests-dev.git

xfstests: honor comments in the test group file

There are some spots in the "group" file where test numbers have
groups listed after a '#' character, clearly intending for those
groups to be commented out.  But the way the group list gets
generated that commenting doesn't work, and in fact these tests
explicitly *are* included in such commented-out groups.

This patch fixes that, stripping out all comments (which start
with a '#' character and end with a newline) from the file before
building the set of test numbers for a group.

Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/common b/common
index 828563de..817c0039 100644
--- a/common
+++ b/common
@@ -58,9 +58,10 @@ do
     if $group
     then
 	# arg after -g
-	group_list=`sed -n <group -e 's/$/ /' -e "/^[0-9][0-9][0-9].* $r /"'{
-s/ .*//p
-}'`
+       group_list=$(sed -n < group \
+                       -e 's/#.*//' \
+                       -e 's/$/ /' \
+                       -e "/^[0-9][0-9][0-9].* $r /"'{ s/ .*//p }')
 	if [ -z "$group_list" ]
 	then
 	    echo "Group \"$r\" is empty or not defined?"