From: Jos Collin <jcollin@redhat.com>
Date: Tue, 19 Sep 2017 06:30:26 +0000 (+0530)
Subject: test: silence warning from -Wsign-compare
X-Git-Tag: v13.0.1~800^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6854af9ab0fb69f36ccfea20758a80aead25e1a0;p=ceph.git

test: silence warning from -Wsign-compare

Fixed warnings:
ceph/src/test/test_xlist.cc:46:3:   required from here
ceph/src/googletest/googletest/include/gtest/gtest.h:1392:11: warning: comparison between
signed and unsigned integer expressions [-Wsign-compare]

ceph/src/test/librados/tier.cc:1360:5:   required from here
ceph/src/googletest/googletest/include/gtest/gtest.h:1526:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

ceph/src/test/librados/tier.cc:1365:2:   required from here
ceph/src/googletest/googletest/include/gtest/gtest.h:1526:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Jos Collin <jcollin@redhat.com>
---

diff --git a/src/test/librados/tier.cc b/src/test/librados/tier.cc
index f84fcccf5bd7..70f9c9445aed 100644
--- a/src/test/librados/tier.cc
+++ b/src/test/librados/tier.cc
@@ -1357,12 +1357,12 @@ TEST_F(LibRadosTwoPoolsPP, ListSnap){
       0, NULL));
     completion->wait_for_safe();
     ASSERT_EQ(0, snap_ret);
-    ASSERT_LT(0, snap_set.clones.size());
+    ASSERT_LT(0u, snap_set.clones.size());
     for (vector<librados::clone_info_t>::const_iterator r = snap_set.clones.begin();
 	r != snap_set.clones.end();
 	++r) {
       if (r->cloneid != librados::SNAP_HEAD) {
-	ASSERT_LT(0, r->snaps.size());
+	ASSERT_LT(0u, r->snaps.size());
       }
     }
   }
diff --git a/src/test/test_xlist.cc b/src/test/test_xlist.cc
index f13bf41dd688..35b62edcf790 100644
--- a/src/test/test_xlist.cc
+++ b/src/test/test_xlist.cc
@@ -43,14 +43,14 @@ protected:
 TEST_F(XlistTest, capability) {
   ItemList list;
   ASSERT_TRUE(list.empty());
-  ASSERT_EQ(list.size(), 0);
+  ASSERT_EQ(0u, list.size());
 
   std::copy(refs.begin(), refs.end(), std::back_inserter(list));
   ASSERT_EQ((size_t)list.size(), refs.size());
 
   list.clear();
   ASSERT_TRUE(list.empty());
-  ASSERT_EQ(list.size(), 0);
+  ASSERT_EQ(0u, list.size());
 }
 
 TEST_F(XlistTest, traverse) {