From: Sage Weil <sage@newdream.net>
Date: Sat, 24 May 2008 13:55:17 +0000 (-0700)
Subject: kclient: end_page_writeback w/ page still locked
X-Git-Tag: v0.3~185^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6951563068c0ceefdf88a847acbf35c416afd96e;p=ceph.git

kclient: end_page_writeback w/ page still locked
---

diff --git a/src/kernel/addr.c b/src/kernel/addr.c
index 997f69256411..00cbbb4baf0f 100644
--- a/src/kernel/addr.c
+++ b/src/kernel/addr.c
@@ -220,8 +220,8 @@ static int ceph_writepage(struct page *page, struct writeback_control *wbc)
 		wbc->pages_skipped++;
 		ceph_set_page_dirty(page);
 	}
-	unlock_page(page);
 	end_page_writeback(page);
+	unlock_page(page);
 	page_cache_release(page);
 	return err;
 }
@@ -450,8 +450,8 @@ get_more_pages:
 					ceph_set_page_dirty(page);
 				}
 				dout(50, "unlocking %d %p\n", i, page);
-				unlock_page(page);
 				end_page_writeback(page);
+				unlock_page(page);
 			}
 			dout(20, "%p cleaned %d pages\n", inode, cleaned);
 			ceph_put_wrbuffer_cap_refs(ci, cleaned);