From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Sun, 15 Sep 2019 14:01:39 +0000 (+0200)
Subject: crimson: don't allocate exception_ptr when returning error code.
X-Git-Tag: v15.1.0~801^2~30
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=69d6de77eda1648ae17620d3ac835d8fb38ff236;p=ceph-ci.git

crimson: don't allocate exception_ptr when returning error code.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/crimson/common/errorator.h b/src/crimson/common/errorator.h
index cee3e43db20..55710106341 100644
--- a/src/crimson/common/errorator.h
+++ b/src/crimson/common/errorator.h
@@ -73,12 +73,19 @@ private:
 
   // implement the errorable interface
   struct throwable_carrier{};
+  static std::exception_ptr carrier_instance;
 
   static constexpr const std::type_info& exception_ptr_type_info() {
     return typeid(throwable_carrier);
   }
   auto to_exception_ptr() const {
-    return std::make_exception_ptr<throwable_carrier>({});
+    // error codes don't need to instantiate `std::exception_ptr` each
+    // time as the code is actually a part of the type itself.
+    // `std::make_exception_ptr()` on modern enough GCCs is quite cheap
+    // (see the Gleb Natapov's patch eradicating throw/catch there),
+    // but using one instance per type boils down the overhead to just
+    // ref-counting.
+    return carrier_instance;
   }
   static const auto& from_exception_ptr(std::exception_ptr) {
     return instance;
@@ -87,6 +94,11 @@ private:
   friend class error_t<unthrowable_wrapper<ErrorT, ErrorV>>;
 };
 
+template <class ErrorT, ErrorT ErrorV>
+std::exception_ptr unthrowable_wrapper<ErrorT, ErrorV>::carrier_instance = \
+  std::make_exception_ptr<
+    unthrowable_wrapper<ErrorT, ErrorV>::throwable_carrier>({});
+
 namespace _impl {
   template <class T> struct always_false : std::false_type {};
 };