From: Radoslaw Zarzynski Date: Tue, 27 Jan 2026 12:19:10 +0000 (+0000) Subject: crimson/os: fix multiple compile-time warnings on unused variables X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=69ffac28a529938af345223c874e6e3ccf2f95a2;p=ceph.git crimson/os: fix multiple compile-time warnings on unused variables Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/crimson/os/seastore/btree/fixed_kv_btree.h b/src/crimson/os/seastore/btree/fixed_kv_btree.h index 15849be4cd0..6f2959606b1 100644 --- a/src/crimson/os/seastore/btree/fixed_kv_btree.h +++ b/src/crimson/os/seastore/btree/fixed_kv_btree.h @@ -678,7 +678,7 @@ public: if (node->is_pending()) { auto &n = node->get_stable_for_key(i->get_key()); assert(cnode->peek_parent_node().get() == &n); - auto pos = n.lower_bound(i->get_key()).get_offset(); + [[maybe_unused]] auto pos = n.lower_bound(i->get_key()).get_offset(); assert(pos < n.get_size()); assert(n.children[pos] == cnode.get()); } else { @@ -687,13 +687,14 @@ public: } } else if (child_node->is_pending()) { if (child_node->is_mutation_pending()) { - auto &prior = (child_node_t &)*child_node->get_prior_instance(); + [[maybe_unused]] auto &prior = + (child_node_t &)*child_node->get_prior_instance(); assert(prior.is_valid()); assert(prior.is_parent_valid()); if (node->is_pending()) { auto &n = node->get_stable_for_key(i->get_key()); assert(prior.peek_parent_node().get() == &n); - auto pos = n.lower_bound(i->get_key()).get_offset(); + [[maybe_unused]] auto pos = n.lower_bound(i->get_key()).get_offset(); assert(pos < n.get_size()); assert(n.children[pos] == &prior); } else { @@ -703,7 +704,7 @@ public: } else { auto cnode = child_node->template cast(); auto pos = node->find(i->get_key()).get_offset(); - auto child = node->children[pos]; + [[maybe_unused]] auto child = node->children[pos]; assert(child); assert(child == cnode.get()); assert(cnode->is_parent_valid()); @@ -746,7 +747,7 @@ public: } } } else { - auto c = static_cast(child); + [[maybe_unused]] auto c = static_cast(child); assert(c->has_parent_tracker()); assert(c->peek_parent_node().get() == node.get() || (node->is_pending() && c->is_stable() @@ -1696,7 +1697,7 @@ private: *parent_entry.node, parent_entry.pos, *child); - auto &cnode = (typename internal_node_t::base_t &)*child; + [[maybe_unused]] auto &cnode = (typename internal_node_t::base_t &)*child; assert(cnode.get_node_meta().begin == node_iter.get_key()); assert(cnode.get_node_meta().end > node_iter.get_key()); return on_found(child->template cast()); @@ -2334,7 +2335,7 @@ private: *parent_pos.node, donor_iter.get_offset(), *child); - auto &node = (typename internal_node_t::base_t&)*child; + [[maybe_unused]] auto &node = (typename internal_node_t::base_t&)*child; assert(donor_is_left ? node.get_node_meta().end == pos.node->get_node_meta().begin : node.get_node_meta().begin == pos.node->get_node_meta().end); diff --git a/src/crimson/os/seastore/lba/btree_lba_manager.cc b/src/crimson/os/seastore/lba/btree_lba_manager.cc index db492e83247..07cfdf8edf9 100644 --- a/src/crimson/os/seastore/lba/btree_lba_manager.cc +++ b/src/crimson/os/seastore/lba/btree_lba_manager.cc @@ -222,7 +222,7 @@ BtreeLBAManager::resolve_indirect_cursor( ).si_then([&indirect_cursor](auto cursors) { ceph_assert(cursors.size() == 1); auto& direct_cursor = cursors.front(); - auto intermediate_key = indirect_cursor.get_intermediate_key(); + [[maybe_unused]] auto intermediate_key = indirect_cursor.get_intermediate_key(); assert(!direct_cursor->is_indirect()); assert(direct_cursor->get_laddr() <= intermediate_key); assert(direct_cursor->get_laddr() + direct_cursor->get_length() diff --git a/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.h b/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.h index 844042d84c6..39e6e770554 100644 --- a/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.h +++ b/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.h @@ -114,7 +114,8 @@ struct OMapInnerNode void do_on_replace_prior() final { this->parent_node_t::on_replace_prior(); if (!this->is_btree_root()) { - auto &prior = *get_prior_instance()->template cast(); + [[maybe_unused]] auto &prior = + *get_prior_instance()->template cast(); assert(prior.base_child_t::has_parent_tracker()); this->child_node_t::on_replace_prior(); } @@ -366,7 +367,8 @@ struct OMapLeafNode void do_on_replace_prior() final { ceph_assert(!this->is_rewrite()); if (!this->is_btree_root()) { - auto &prior = *get_prior_instance()->template cast(); + [[maybe_unused]] auto &prior = + *get_prior_instance()->template cast(); assert(prior.base_child_t::has_parent_tracker()); this->child_node_t::on_replace_prior(); }