From: Alex Ainscow <aainscow@uk.ibm.com>
Date: Tue, 15 Jul 2025 10:50:20 +0000 (+0100)
Subject: osd: Use std::cmp_greater to avoid signedness warnings.
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=6b4c5c16c28c622e407dcde22a9f8105d67547e5;p=ceph.git

osd: Use std::cmp_greater to avoid signedness warnings.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
(cherry picked from commit 846879e6c2ec4ab5a65040981a617f4b603c379a)
---

diff --git a/src/osd/ECTransaction.cc b/src/osd/ECTransaction.cc
index 9f2a02d78a811..13c2428b94a49 100644
--- a/src/osd/ECTransaction.cc
+++ b/src/osd/ECTransaction.cc
@@ -608,7 +608,7 @@ ECTransaction::Generate::Generate(PGTransaction &t,
    * not simply construct written shards here.
    */
   for (auto &&[shard, t] : transactions) {
-    if (t.get_num_ops() > old_transaction_counts[int(shard)] &&
+    if (std::cmp_greater(t.get_num_ops(), old_transaction_counts[int(shard)]) &&
         !entry->is_written_shard(shard)) {
       ldpp_dout(dpp, 20) << __func__ << " Transaction for shard " << shard << ": ";
       Formatter *f = Formatter::create("json");