From: Danny Al-Gaaf Date: Tue, 5 Nov 2013 18:42:29 +0000 (+0100) Subject: ErasureCodeJerasure.cc: prefer prefix ++operator for non-primitive types X-Git-Tag: v0.74~90^2~1^2~10 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6b5a96b1f1b2b88f1a57cd84f3de5ae70ed76409;p=ceph.git ErasureCodeJerasure.cc: prefer prefix ++operator for non-primitive types Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf --- diff --git a/src/osd/ErasureCodePluginJerasure/ErasureCodeJerasure.cc b/src/osd/ErasureCodePluginJerasure/ErasureCodeJerasure.cc index f2be1ed06e71..fe656e58ee00 100644 --- a/src/osd/ErasureCodePluginJerasure/ErasureCodeJerasure.cc +++ b/src/osd/ErasureCodePluginJerasure/ErasureCodeJerasure.cc @@ -54,7 +54,7 @@ int ErasureCodeJerasure::minimum_to_decode(const set &want_to_read, return -EIO; set::iterator i; unsigned j; - for (i = available_chunks.begin(), j = 0; j < (unsigned)k; i++, j++) + for (i = available_chunks.begin(), j = 0; j < (unsigned)k; ++i, j++) minimum->insert(*i); } return 0; @@ -67,7 +67,7 @@ int ErasureCodeJerasure::minimum_to_decode_with_cost(const set &want_to_rea set available_chunks; for (map::const_iterator i = available.begin(); i != available.end(); - i++) + ++i) available_chunks.insert(i->first); return minimum_to_decode(want_to_read, available_chunks, minimum); }