From: Omar Sandoval <osandov@fb.com>
Date: Sun, 31 Jul 2016 21:53:44 +0000 (-0700)
Subject: check: allow comments in exclude files
X-Git-Tag: v2022.05.01~2414
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=6ba4f8a858a52f8f6fed3acbcc0e940fdad60358;p=xfstests-dev.git

check: allow comments in exclude files

Sometimes it's useful to keep track of why we're excluding a particular
test. Technically, we can include whatever explanation we want in the
exclude file since we just grep for the test names, but properly
supporting comments is a little more robust. This patch makes it so that
the rest of a line after a '#' is ignored.

Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
---

diff --git a/check b/check
index 9fbc305e..69341d8c 100755
--- a/check
+++ b/check
@@ -224,14 +224,14 @@ while [ $# -gt 0 ]; do
 	-X)	xfile=$2; shift ;
 		for d in $SRC_GROUPS $FSTYP; do
 			[ -f $SRC_DIR/$d/$xfile ] || continue
-			for f in `cat $SRC_DIR/$d/$xfile`; do
+			for f in `sed "s/#.*$//" $SRC_DIR/$d/$xfile`; do
 				echo $d/$f >> $tmp.xlist
 			done
 		done
 		;;
 	-E)	xfile=$2; shift ;
 		if [ -f $xfile ]; then
-			cat "$xfile" >> $tmp.xlist
+			sed "s/#.*$//" "$xfile" >> $tmp.xlist
 	        fi
 		;;
 	-s)	RUN_SECTION="$RUN_SECTION $2"; shift ;;