From: Christopher Hoffman Date: Tue, 3 Jun 2025 15:13:16 +0000 (+0000) Subject: Address misc comments X-Git-Tag: testing/wip-vshankar-testing-20260120.085915-debug^2~13^2~42 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6cf17e76b0bae7455581f0002fb79ffc2f1858a1;p=ceph-ci.git Address misc comments Signed-off-by: Christopher Hoffman --- diff --git a/src/client/FSCrypt.cc b/src/client/FSCrypt.cc index 32269b0afb9..d3f162c8af2 100644 --- a/src/client/FSCrypt.cc +++ b/src/client/FSCrypt.cc @@ -42,12 +42,13 @@ using ceph::crypto::HMACSHA512; -/* FIXME: this was copy pasted from common/armor.c with slight modification +/* FIXME: Use boost or similar library to roll your own + * FIXME: this was copy pasted from common/armor.c with slight modification * as needed to use alternative translation table. Code can and should be * combined, but need to make sure we do it in a way that doesn't hurt * compiler optimizations in the general case. * Also relaxed decoding to make it compatible with the kernel client */ -static const char *pem_key = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+,"; +static const char pem_key[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+,"; static int encode_bits(int c) {