From: Sage Weil Date: Mon, 15 Jul 2013 16:58:08 +0000 (-0700) Subject: rgw: fix more warnings X-Git-Tag: v0.67-rc1~71^2~2^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6d3e13f0e139e215d378e0a040e8b856938fe9d3;p=ceph.git rgw: fix more warnings test/test_rgw_admin_opstate.cc: In member function 'int admin_log::test_helper::extract_input(int, char**)': warning: test/test_rgw_admin_opstate.cc:129:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:131:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:133:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:135:24: comparison between signed and unsigned integer expressions [-Wsign-compare] test/test_rgw_admin_log.cc: In member function 'int admin_log::test_helper::extract_input(int, char**)': warning: test/test_rgw_admin_log.cc:132:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:134:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:136:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:138:24: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Sage Weil --- diff --git a/src/test/test_rgw_admin_log.cc b/src/test/test_rgw_admin_log.cc index 876c76973e05..67ba0b12d968 100644 --- a/src/test/test_rgw_admin_log.cc +++ b/src/test/test_rgw_admin_log.cc @@ -124,7 +124,7 @@ class test_helper { int test_helper::extract_input(int argc, char *argv[]){ #define ERR_CHECK_NEXT_PARAM(o) \ - if((loop + 1) >= argc)return -1; \ + if(((int)loop + 1) >= argc)return -1; \ else o = argv[loop+1]; for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){ diff --git a/src/test/test_rgw_admin_opstate.cc b/src/test/test_rgw_admin_opstate.cc index cfd709043dd6..8f95db4cee0d 100644 --- a/src/test/test_rgw_admin_opstate.cc +++ b/src/test/test_rgw_admin_opstate.cc @@ -121,7 +121,7 @@ class test_helper { int test_helper::extract_input(int argc, char *argv[]){ #define ERR_CHECK_NEXT_PARAM(o) \ - if((loop + 1) >= argc)return -1; \ + if(((int)loop + 1) >= argc)return -1; \ else o = argv[loop+1]; for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){