From: Guillaume Abrioux <gabrioux@ibm.com>
Date: Thu, 12 Feb 2026 15:08:39 +0000 (+0100)
Subject: node-proxy: get serial number instead of SKU
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6db965b9946c437e4c1f508a95d15aec079baa16;p=ceph.git

node-proxy: get serial number instead of SKU

Let's get the serial number instead of SKU.

Fixes: https://tracker.ceph.com/issues/74749

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
---

diff --git a/src/ceph-node-proxy/ceph_node_proxy/baseredfishsystem.py b/src/ceph-node-proxy/ceph_node_proxy/baseredfishsystem.py
index b5103f0d8ae..4c4051951f1 100644
--- a/src/ceph-node-proxy/ceph_node_proxy/baseredfishsystem.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/baseredfishsystem.py
@@ -225,7 +225,7 @@ class BaseRedfishSystem(BaseSystem):
         self._system[update_service_members.id] = update_service_members.data
 
     def get_sn(self) -> str:
-        return str(self._sys.get("SKU", ""))
+        return str(self._sys.get("SN", ""))
 
     def get_status(self) -> Dict[str, Dict[str, Dict]]:
         return dict(self._sys.get("status", {}))
@@ -346,9 +346,11 @@ class BaseRedfishSystem(BaseSystem):
         serials: List[str] = []
         self.log.debug("Updating serial number")
         data: Dict[str, Any] = self.endpoints["systems"].get_members_data()
-        for sys in data.keys():
-            serials.append(data[sys]["SKU"])
-        self._sys["SKU"] = ",".join(serials)
+        for chassis_id in data:
+            serial = data[chassis_id].get("SerialNumber")
+            if serial:
+                serials.append(serial)
+        self._sys["SN"] = ",".join(serials)
 
     def _update_memory(self) -> None:
         self._run_update("memory")
diff --git a/src/ceph-node-proxy/tests/test_baseredfishsystem.py b/src/ceph-node-proxy/tests/test_baseredfishsystem.py
index cb693fc9f66..adac813a54c 100644
--- a/src/ceph-node-proxy/tests/test_baseredfishsystem.py
+++ b/src/ceph-node-proxy/tests/test_baseredfishsystem.py
@@ -81,7 +81,7 @@ class TestBaseRedfishSystemGetters:
         assert system.get_sn() == ""
 
     def test_get_sn_from_sys(self, system):
-        system._sys["SKU"] = "ABC123"
+        system._sys["SN"] = "ABC123"
         assert system.get_sn() == "ABC123"
 
     def test_get_memory_empty(self, system):
@@ -115,7 +115,7 @@ class TestBaseRedfishSystemGetters:
 
 class TestBaseRedfishSystemGetSystem:
     def test_get_system_structure(self, system):
-        system._sys["SKU"] = "SN1"
+        system._sys["SN"] = "SN1"
         system._sys["memory"] = {}
         system._sys["processors"] = {}
         system._sys["network"] = {}