From: Milind Changire <mchangir@redhat.com>
Date: Tue, 17 Oct 2023 04:36:48 +0000 (+0530)
Subject: snap_schedule/tests: fix db upgrade issue
X-Git-Tag: v17.2.8~451^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=6e60da6477f64acdd702aae5dc93440bbf0358af;p=ceph.git

snap_schedule/tests: fix db upgrade issue

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit dfc35a4679495a3d7136927374e838409c29ab4a)
---

diff --git a/src/pybind/mgr/snap_schedule/tests/conftest.py b/src/pybind/mgr/snap_schedule/tests/conftest.py
index 35255b8d486b0..92d4c9bc132be 100644
--- a/src/pybind/mgr/snap_schedule/tests/conftest.py
+++ b/src/pybind/mgr/snap_schedule/tests/conftest.py
@@ -31,4 +31,41 @@ def db():
         db.row_factory = sqlite3.Row
         db.execute("PRAGMA FOREIGN_KEYS = 1")
         db.executescript(Schedule.CREATE_TABLES)
+        _create_snap_schedule_kv_db(db)
+        _upgrade_snap_schedule_db_schema(db)
     return db
+
+def _create_snap_schedule_kv_db(db):
+    SQL = """
+    CREATE TABLE IF NOT EXISTS SnapScheduleModuleKV (
+      key TEXT PRIMARY KEY,
+      value NOT NULL
+    ) WITHOUT ROWID;
+    INSERT OR IGNORE INTO SnapScheduleModuleKV (key, value) VALUES ('__snap_schedule_db_version', 1);
+    """
+    db.executescript(SQL)
+
+def _get_snap_schedule_db_version(db):
+    SQL = """
+    SELECT value
+    FROM SnapScheduleModuleKV
+    WHERE key = '__snap_schedule_db_version';
+    """
+    cur = db.execute(SQL)
+    row = cur.fetchone()
+    assert row is not None
+    return int(row[0])
+
+# add all upgrades here
+def _upgrade_snap_schedule_db_schema(db):
+    # add a column to hold the subvolume group name
+    if _get_snap_schedule_db_version(db) < 2:
+        SQL = """
+        ALTER TABLE schedules
+        ADD COLUMN group_name TEXT;
+        """
+        db.executescript(SQL)
+
+        # bump up the snap-schedule db version to 2
+        SQL = "UPDATE OR ROLLBACK SnapScheduleModuleKV SET value = ? WHERE key = '__snap_schedule_db_version';"
+        db.execute(SQL, (2,))