From: Kefu Chai <kchai@redhat.com>
Date: Mon, 7 Jun 2021 08:00:23 +0000 (+0800)
Subject: cmake: let vstart-base depend on cython_rados if NOT WIN32
X-Git-Tag: v17.1.0~1728^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6eacbdcac18dbe4500f455ec1489caaba1e84baa;p=ceph.git

cmake: let vstart-base depend on cython_rados if NOT WIN32

to disable this custom target if NOT WIN32 without explanations is difficult
to maintain, so add a comment, and limit the scope to just
`cython_rados`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index ed69b15fbef4..73b3279505c6 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -891,7 +891,6 @@ configure_file(
   ${CMAKE_BINARY_DIR}/include/acconfig.h
 )
 
-if(NOT WIN32)
 # Everything you need to spin up a cluster with vstart.sh
 add_custom_target(vstart-base DEPENDS
     ceph-osd
@@ -900,8 +899,14 @@ add_custom_target(vstart-base DEPENDS
     ceph-conf
     monmaptool
     crushtool
-    rados
+    rados)
+if(NOT WIN32)
+  # WIN32 port does not build python bindings
+  # TODO: introduce an option for enabling python binding
+  add_dependencies(vstart-base
     cython_rados)
+endif()
+
 if (WITH_MGR)
   add_dependencies(vstart-base ceph-mgr)
 endif()
@@ -928,7 +933,6 @@ endif()
 if(WITH_MGR)
   add_dependencies(vstart ceph-volume-venv-setup)
 endif()
-endif(NOT WIN32)
 
 # Everything you need to run CephFS tests
 add_custom_target(cephfs_testing DEPENDS