From: xie xingguo Date: Tue, 22 Mar 2016 07:36:35 +0000 (+0800) Subject: osd: drop duplicated put of message X-Git-Tag: v10.1.1~97^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6ed9c3fe0b55cb8863c4d9fc9f3465be6a11ec6e;p=ceph.git osd: drop duplicated put of message On returning false, the require_mon_peer() will internally decrease the reference of the input message. So the put() method here is duplicated and will cause reference underflow and thus need to be dropped. Signed-off-by: xie xingguo --- diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 298d65df454f..b3b584538997 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -5070,7 +5070,6 @@ void OSD::handle_pg_stats_ack(MPGStatsAck *ack) dout(10) << "handle_pg_stats_ack " << dendl; if (!require_mon_peer(ack)) { - ack->put(); return; }