From: Kefu Chai <kchai@redhat.com>
Date: Thu, 13 May 2021 16:02:47 +0000 (+0800)
Subject: crimson/net/Socket: do not reset FixedCPUServerSocket::shutdown_gate
X-Git-Tag: v17.1.0~1969^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=6ee29c6642fa223f51602768abcb42132b4f949d;p=ceph-ci.git

crimson/net/Socket: do not reset FixedCPUServerSocket::shutdown_gate

the copy constructor of seastar::gate is deleted explicitly. so we
cannot reset FixedCPUServerSocket::shutdown_gate by assigning a new
seastar::gate to it.

since we don't reuse a FixedCPUServerSocket after calling
FixedCPUServerSocket::destroy(), it's safe to leave a closed gate after
calling FixedCPUServerSocket::reset()

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/net/Socket.h b/src/crimson/net/Socket.h
index d39a2517f95..9cb3006ea55 100644
--- a/src/crimson/net/Socket.h
+++ b/src/crimson/net/Socket.h
@@ -179,7 +179,6 @@ class FixedCPUServerSocket
   seastar::future<> reset() {
     return container().invoke_on_all([] (auto& ss) {
       assert(ss.shutdown_gate.is_closed());
-      ss.shutdown_gate = seastar::gate();
       ss.addr = entity_addr_t();
       ss.listener.reset();
     });