From: Alfredo Deza Date: Sat, 21 Apr 2018 00:10:31 +0000 (-0400) Subject: Merge pull request #21455 from dmick/wip-ceph-volume X-Git-Tag: v13.1.0~168 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=6f60a995de5645667f2c330d03459a7a9ca469f9;p=ceph.git Merge pull request #21455 from dmick/wip-ceph-volume ceph-volume: Nits noticed while studying code --- 6f60a995de5645667f2c330d03459a7a9ca469f9 diff --cc src/ceph-volume/ceph_volume/api/lvm.py index e9dbb0b22885c,328b887d09bad..88f0d2d2af6dd --- a/src/ceph-volume/ceph_volume/api/lvm.py +++ b/src/ceph-volume/ceph_volume/api/lvm.py @@@ -172,9 -76,9 +172,9 @@@ def get_api_vgs() Return the list of group volumes available in the system using flags to include common metadata associated with them - Command and sample delimeted output, should look like:: + Command and sample delimited output should look like:: - $ vgs --noheadings --separator=';' \ + $ vgs --noheadings --readonly --separator=';' \ -o vg_name,pv_count,lv_count,snap_count,vg_attr,vg_size,vg_free ubuntubox-vg;1;2;0;wz--n-;299.52g;12.00m osd_vg;3;1;0;wz--n-;29.21g;9.21g @@@ -192,9 -96,9 +192,9 @@@ def get_api_lvs() Return the list of logical volumes available in the system using flags to include common metadata associated with them - Command and delimeted output, should look like:: + Command and delimited output should look like:: - $ lvs --noheadings --separator=';' -o lv_tags,lv_path,lv_name,vg_name + $ lvs --noheadings --readonly --separator=';' -o lv_tags,lv_path,lv_name,vg_name ;/dev/ubuntubox-vg/root;root;ubuntubox-vg ;/dev/ubuntubox-vg/swap_1;swap_1;ubuntubox-vg @@@ -213,9 -117,9 +213,9 @@@ def get_api_pvs() This will only return physical volumes set up to work with LVM. - Command and delimeted output, should look like:: + Command and delimited output should look like:: - $ pvs --noheadings --separator=';' -o pv_name,pv_tags,pv_uuid + $ pvs --noheadings --readonly --separator=';' -o pv_name,pv_tags,pv_uuid /dev/sda1;; /dev/sdv;;07A4F654-4162-4600-8EB3-88D1E42F368D