From: Kefu Chai <kchai@redhat.com>
Date: Sat, 8 Jul 2017 12:18:18 +0000 (+0800)
Subject: mgr/PyState: fix leak if `type` is unknown
X-Git-Tag: v12.1.1~80^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=6f7bcfbfd7f43e5e4ad827bc86980558f56a8041;p=ceph.git

mgr/PyState: fix leak if `type` is unknown

this silences a clang analyzer warning:

Potential leak of memory pointed to by 'c'

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/mgr/PyState.cc b/src/mgr/PyState.cc
index 963526fc519d..78b0cb542321 100644
--- a/src/mgr/PyState.cc
+++ b/src/mgr/PyState.cc
@@ -172,6 +172,7 @@ ceph_send_command(PyObject *self, PyObject *args)
         c);
     return nullptr;
   } else {
+    delete c;
     string msg("unknown service type: ");
     msg.append(type);
     PyErr_SetString(PyExc_ValueError, msg.c_str());